Skip to content

Add support for AWS Bedrock LLM integration #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

onyedikachi-david
Copy link

@onyedikachi-david onyedikachi-david commented May 9, 2025

  • Introduced golem-llm-bedrock component with necessary dependencies and configurations.
  • Updated Cargo.toml and Makefile.toml to include new build tasks for Bedrock.
  • Enhanced README.md to document the new Bedrock LLM implementation.
  • Implemented client and conversion logic for interacting with AWS Bedrock APIs.
  • Added streaming support and message conversion for Bedrock models.
  • Updated test configurations to include Bedrock component builds.

Fixes: #2
/claim #2

- Introduced `golem-llm-bedrock` component with necessary dependencies and configurations.
- Updated `Cargo.toml` and `Makefile.toml` to include new build tasks for Bedrock.
- Enhanced `README.md` to document the new Bedrock LLM implementation.
- Implemented client and conversion logic for interacting with AWS Bedrock APIs.
- Added streaming support and message conversion for Bedrock models.
- Updated test configurations to include Bedrock component builds.

Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
@vigoo
Copy link
Collaborator

vigoo commented May 19, 2025

  • You are not using the wasi-http based http connector (https://crates.io/crates/aws-smithy-wasm) so I doubt this was tried out with Goelm
  • Streaming is not implemented; even if it is not possible to use the existing wrapper code that is based on reqwest because of using the AWS library, it must be implemented in some way:
    • either do your own version of what's implemented for the other providers in a generic way, based on the AWS response types
    • or use reqwest to manually set up requests for bedrock instead of using the aws sdk

@jdegoes
Copy link
Contributor

jdegoes commented May 22, 2025

@onyedikachi-david This still has a LONG ways to go, please re-open when ready.

@jdegoes jdegoes closed this May 22, 2025
…ng - AWS credentials handling, tool calls, data URL images, test integration
@onyedikachi-david
Copy link
Author

Hello, @jdegoes, I have been working on it, I have a full implementation here, please reopen, or should I open another PR?

@jdegoes jdegoes reopened this May 24, 2025
@onyedikachi-david
Copy link
Author

Open for review @vigoo

@jdegoes
Copy link
Contributor

jdegoes commented May 27, 2025

@onyedikachi-david There are many conflicts, I suggest resolving all conflicts first.

@onyedikachi-david
Copy link
Author

Done @jdegoes

onyedikachi-david and others added 2 commits May 27, 2025 13:31
Signed-off-by: David Anyatonwu <davidanyatonwu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS Bedrock Provider
3 participants