Skip to content

fix: multi turn convo #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: multi turn convo #56

wants to merge 2 commits into from

Conversation

dfordp
Copy link

@dfordp dfordp commented Jul 1, 2025

/close #53
/claim #53

The fix involved:

Updating the API endpoint from /v1/responses to /v1/chat/completions
Updating the request/response structures to match the Chat Completions API
Fixing message conversion for multi-turn conversations
Adding proper streaming support
The tests confirm that:

✅ Message structure is correct for multi-turn conversations
✅ Request creation works properly
✅ Tool results are handled correctly
✅ Finish reason conversion works
✅ The fix addresses the root cause of the 400 error

@dfordp
Copy link
Author

dfordp commented Jul 1, 2025

I was facing some issues in windows due in the
/wasio:io files seem deleted, tried out diff stuff but to no avail
Any Idea how to fix it

@Nanashi-lab
Copy link
Contributor

There is no fix for windows : not a valid folder/file name. For more details - #1 and bytecodealliance/wit-deps#285, you can use wsl filesystem within wsl and that is a workaround for this.

@rvolosatovs
Copy link

@dfordp you should be able to fix the issue by rebasing on #70

@dfordp
Copy link
Author

dfordp commented Jul 15, 2025

Okay @rvolosatovs sir, I will try it again and push

@dfordp
Copy link
Author

dfordp commented Jul 16, 2025

@Nanashi-lab I have rebased over the windows compatibility branch created by @rvolosatovs

Can you please review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: llm/openai fails with 400 error in multi-turn conversations
3 participants