-
Notifications
You must be signed in to change notification settings - Fork 61
feat: added common embeddings providers components #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…and makefile.toml
OpenAIOpenAI.Embed_compressed.mp4 |
HFHF.Embed_compressed.mp4 |
CohereCohere.Embed_compressed.mp4 |
VoyageAIVoyageAI.Embed_compressed.mp4 |
You might want to remove these videos and change them to a version that does not PUBLICLY expose your API Keys? |
Thanks man!! I deleted keys after recording the videos.🙌 |
Alright I was scared for you for a minute 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some helpful comments.
You also need to update this line
and
with entries like: embed_openai, embed_cohere, embed_voyageai
EDIT:
A better solution is to add a copy-release-artifacts and copy-debug-artifacts to the makefiles in the domains instead and call them from the parent Makefile.
I wrote it this way at a time when I was struggling with calling external makefiles in duckscript but that is no longer a challenge. You can edit it to reflect this behavior. That would help prevent the scope of a particular domain spilling into the general Makefile at the root
@vigoo Microsoft is discontinuing the Bing search api in August. Should I still add it? all others are implemented and tested |
Currently, some providers do not support reranking, and some providers do not support image embedding generation
/closes #16
/claim #16