Skip to content

Durability and test fixes, various cleanups #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 24, 2025

Conversation

noise64
Copy link
Contributor

@noise64 noise64 commented Jul 23, 2025

  • fix to use persist instead of persist_infallible for results that can fail
  • logging cleanups: add init_logging helper, and move logging init to the durabilty wrappers: this way we do not have to repeat them in the specific providers and the common parts can also use logging
  • regenerated bindings with the proper cargo component version
  • fixed not failing on cargo-make exec commands
  • the above two revealed problems with our test components (which should have been red): separated the tests for the different areas, so they can be tested in isolation, and fixed other compilation / binding related issues

@noise64 noise64 changed the title Search: durability fix and cleanups Durability and test fixes, various cleanups Jul 23, 2025
@noise64 noise64 requested a review from vigoo July 24, 2025 08:05
Copy link
Collaborator

@vigoo vigoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want logging to be set up in the portable builds too

@noise64 noise64 merged commit abc593d into main Jul 24, 2025
4 of 5 checks passed
@noise64 noise64 deleted the search-durability-fix-and-cleanups branch July 24, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants