Fix:#58 Fail CI if Ollama model not found #62
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschuwalow
requested changes
Jul 17, 2025
| @@ -149,6 +149,12 @@ jobs: | |||
| golem-cli worker invoke test:llm/ollama-1 test5 | |||
| golem-cli worker invoke test:llm/ollama-1 test6 | |||
| golem-cli worker invoke test:llm/ollama-1 test7 | |||
| - name:Fail CI if "model not found" errors exist | |||
| run: | | |||
There was a problem hiding this comment.
Better to check the output the worker invokes and fail the step immediately
|
Closing as the issue is fixed, thank you for your work though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #58
/issue : #58
Fixes #58
This ensures that if any model used in the Ollama integration tests is missing or not pulled correctly, the CI job will fail by scanning Ollama container logs for
"model .* not found"errors. This prevents false-positive test passes when models are not actually running.