Skip to content

feat: aws bedrock llm implementation #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

Rutik7066
Copy link
Contributor

@Rutik7066 Rutik7066 commented Jun 26, 2025

Added AWS bedrock via its converse api link

  • Used AWS bedrock api, which is the same as other LLM providers.
  • Does not use any extra crates like AWS Bedrock, tokio, which leads to smaller builds except aws-smithy-eventstream which need to parse stream events
  • Supports polling

closes #2
/claim #2

@algora-pbc algora-pbc bot mentioned this pull request Jun 26, 2025
@Rutik7066 Rutik7066 marked this pull request as draft June 26, 2025 10:17
@Rutik7066 Rutik7066 marked this pull request as ready for review June 30, 2025 09:24
@mschuwalow
Copy link
Contributor

Please add a short video showcasing the passing testcases

@Rutik7066
Copy link
Contributor Author

@mschuwalow Hi here the link to the video https://drive.google.com/file/d/1LHxIgjyz8l7pM0uAUq3J_8D3caLoUJG2/view?usp=sharing showcasing the testing and I was facing some problem related golem. Which I talked about on hackathon channel https://discord.com/channels/1134448700572319785/1157293164512690267/1389291819925246093

@Rutik7066
Copy link
Contributor Author

All test passes individually but when run in sync one after one then test 3rd or some times 4th fails. I guess it is may be because my system configurations

@Rutik7066
Copy link
Contributor Author

@mschuwalow @vigoo Please check here

@mschuwalow Hi here the link to the video https://drive.google.com/file/d/1LHxIgjyz8l7pM0uAUq3J_8D3caLoUJG2/view?usp=sharing showcasing the testing and I was facing some problem related golem. Which I talked about on hackathon channel https://discord.com/channels/1134448700572319785/1157293164512690267/1389291819925246093

@Rutik7066
Copy link
Contributor Author

Rutik7066 commented Jul 7, 2025

@mschuwalow Please check this demo video

bedrock.2.mp4

@Rutik7066 Rutik7066 marked this pull request as draft July 10, 2025 12:41
@Rutik7066 Rutik7066 marked this pull request as ready for review July 10, 2025 12:41
Copy link
Contributor

@mschuwalow mschuwalow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very reasonable implementation on top of the raw HTTP client.
I'll discuss with my colleagues whether we prefer this approach or the one in #27 from a maintenance perspective.

@vigoo
Copy link
Collaborator

vigoo commented Jul 19, 2025

Closing as we chose to merge the other attempt (#27). Thank you for your work!

@vigoo vigoo closed this Jul 19, 2025
@Rutik7066 Rutik7066 deleted the bedrock branch July 23, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add AWS Bedrock Provider
3 participants