Skip to content

Conversation

@Nathan-Schwartz
Copy link

@Nathan-Schwartz Nathan-Schwartz commented Sep 5, 2021

Changes:

User facing:

  • Expose TS typings Added a typings file to work with Type Script #4
  • Switch to ESM
  • Allow stopping and starting a node Gracefully close #9
  • Add an autoStart option
  • Add an enableStrictWeightMode option to be more aggressive about making the highest-weighted node the leader (may help with Cluster leader election multiple issues mKeRix/room-assistant#860)
  • Change isLeader() implementation such that it isn't reliant on object key iteration order, which could have potentially returned false if the current node was a leader and another node was still reporting themself as a leader. If this occurred, it would mean the runoff elections might not occur when necessary, which could result in multiple leaders existing indefinitely.

Dev facing:

@Nathan-Schwartz Nathan-Schwartz marked this pull request as ready for review September 5, 2021 05:48
@Nathan-Schwartz
Copy link
Author

Hey @goldfire, I'm sure you're busy but I'd love to get some feedback on this when you get time 🙂

@Nathan-Schwartz
Copy link
Author

@goldfire do you have an idea of when you'll get a chance to review this? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant