chore: make random sequence resolver more random #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README documentation to improve clarity in the instructions regarding Snowflake and Sonyflake usage, with a special focus on the new random sequence resolver feature.
- Corrected phrasing for better grammatical clarity.
- Added an example code snippet to demonstrate setting up the random sequence resolver.
- Reordered and renumbered the usage steps for consistency.
Files not reviewed (7)
- src/RandomSequenceResolver.php: Language not supported
- src/Snowflake.php: Language not supported
- tests/FileLockResolverTest.php: Language not supported
- tests/PredisSequenceResolverTest.php: Language not supported
- tests/RandomSequenceResolverTest.php: Language not supported
- tests/RedisSequenceResolverTest.php: Language not supported
- tests/SwooleSequenceResolverTest.php: Language not supported
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
============================================
+ Coverage 98.71% 99.16% +0.44%
- Complexity 91 94 +3
============================================
Files 7 8 +1
Lines 234 240 +6
============================================
+ Hits 231 238 +7
+ Misses 3 2 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
godruoyi
commented
Apr 30, 2025
godruoyi
added
the
Ready to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
workIdanddatacenterIdwill be randomly between 0 and 31 if not set.RandomSequenceResolver.This is a breaking change as we have updated the default behavior when creating a Snowflake instance.