Skip to content

Make Devlog available to feed readers #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

TitanNano
Copy link
Contributor

Enabling the atom feed and linking it inside the devlog pages makes it possible for feed readers to subscribe to the devlog.

@Bromeon Bromeon added the ci-cd Website deployment, doc generation CI/CD label Oct 15, 2024
@Bromeon
Copy link
Member

Bromeon commented Oct 15, 2024

Thanks! There seems to be a configuration error, generate_feeds instead of generate_feed?

As I'm not using feeds myself, could you maybe test this somehow?

@TitanNano
Copy link
Contributor Author

@Bromeon I somehow came to the conclusion that the project is using zola 0.18.0, but now I see CI is using 0.19. The config was changed between the two versions.

@TitanNano
Copy link
Contributor Author

Ah so check-website uses zola master which is 0.19.2 but deploy-website uses zola 0.18.0

@Bromeon
Copy link
Member

Bromeon commented Oct 15, 2024

Ah, we could align the two, latest is still 0.19.2.

@TitanNano
Copy link
Contributor Author

Ah, we could align the two, latest is still 0.19.2.

I aligned it on 0.18.0 for now. There are some breaking changes in 0.19.0, and I wasn't able to build the site with 0.19.

@Bromeon
Copy link
Member

Bromeon commented Oct 15, 2024

That just delays the problem though, and means that next version update comes with extra work.

What breaking changes did you encounter?

@TitanNano TitanNano force-pushed the jovan/atom_feed branch 2 times, most recently from 2fe32b6 to 8970fb0 Compare October 15, 2024 18:47
@TitanNano
Copy link
Contributor Author

Error: Failed to build the site
Error: Error when parsing front matter of section `/Users/jovan/godot-rust.github.io/website/content/docs/_index.md`
Error: Reason: TOML parse error at line 9, column 1
  |
9 | date = 2000-01-01
  | ^^^^
unknown field `date`, expected one of `title`, `description`, `sort_by`, `weight`, `draft`, `template`, `paginate_by`, `paginate_reversed`, `paginate_path`, `insert_anchor_links`, `render`, `redirect_to`, `in_search_index`, `transparent`, `page_template`, `aliases`, `generate_feeds`, `extra`

Apparently, the index file can no longer have a date.

@Bromeon Bromeon merged commit 88cdf24 into godot-rust:master Oct 21, 2024
3 checks passed
@Bromeon Bromeon mentioned this pull request Oct 21, 2024
@Bromeon
Copy link
Member

Bromeon commented Oct 21, 2024

Thanks a lot! 🙂

According to https://godot-rust.github.io/atom.xml, it looks like pull request and other site updates are also contained. Do you know how I can limit this to the /dev/* path? I don't want to spam everyone subscribing to articles. Unfortunately, Zola docs on Feeds are quite brief...

(Note to myself, in Firefox there's the Livemarks addon)

@TitanNano
Copy link
Contributor Author

@Bromeon yeah so when I tested it with the livemarks add-on it only showed the devlog pages, but when I subscribed yesterday the other pages also showed up. Could be that I tested with a local build of the site and that does not generate the other updates? I will look into it, though. 😅 I thought I saw something to exclude pages from the feed.

@Bromeon
Copy link
Member

Bromeon commented Oct 23, 2024

Adjusted in #8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-cd Website deployment, doc generation CI/CD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants