Skip to content

Commit f89f90b

Browse files
committed
Fix leak, add --verbose to CI itest runs
Without the flag, Godot will not emit "Leaked instance" messages we're looking for in CI. The leak was introduced in #1002, in the `test_nil_object_return_value` test.
1 parent 73169b5 commit f89f90b

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/composite/godot/action.yml

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -62,25 +62,25 @@ runs:
6262
cd test;
6363
mkdir -p ./project/lib;
6464
cp ../target/debug/libgdnative_test.so ./project/lib/;
65-
${GODOT_BIN} --path ./project/ > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
65+
${GODOT_BIN} --verbose --path ./project/ > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
6666
bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
6767
if [[ $? -ne 0 ]]; then
6868
exit 1;
6969
fi;
70-
${GODOT_BIN} -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
70+
${GODOT_BIN} --verbose -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
7171
bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
7272
if [[ $? -ne 0 ]]; then
7373
exit 1;
7474
fi;
7575
cargo build --features type-tag-fallback ${{ inputs.rust_extra_args }}
7676
mkdir -p ./project/lib;
7777
cp ../target/debug/libgdnative_test.so ./project/lib/;
78-
${GODOT_BIN} --path ./project/ > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
78+
${GODOT_BIN} --verbose --path ./project/ > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
7979
bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
8080
if [[ $? -ne 0 ]]; then
8181
exit 1;
8282
fi;
83-
${GODOT_BIN} -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
83+
${GODOT_BIN} --verbose -e --path ./project/ --run-editor-tests > >(tee "${{ runner.temp }}/stdout.log") 2> >(tee "${{ runner.temp }}/stderr.log");
8484
bash ../tools/check-test-output.sh "${{ runner.temp }}/stdout.log" "${{ runner.temp }}/stderr.log";
8585
if [[ $? -ne 0 ]]; then
8686
exit 1;

test/src/lib.rs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -104,6 +104,7 @@ godot_itest! {
104104
// Should not panic due to conversion failure
105105
let option = node.get_node("does not exist");
106106
assert!(option.is_none());
107+
node.free();
107108
}
108109
}
109110

0 commit comments

Comments
 (0)