Skip to content

Commit 73169b5

Browse files
committed
Impl invalid accessors for inconvertible types
The invalid accessors used to require conversion traits for the property types. This prevented users from registering read-only properties of types that only implement `ToVariant`.
1 parent 56fbb4c commit 73169b5

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

gdnative-core/src/export/property/invalid_accessor.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
33
use std::mem;
44

5-
use crate::core_types::{FromVariant, ToVariant, Variant};
5+
use crate::core_types::Variant;
66
use crate::export::{class_registry, NativeClass};
77

88
use super::accessor::{RawGetter, RawSetter};
@@ -78,7 +78,7 @@ extern "C" fn invalid_free_func(data: *mut libc::c_void) {
7878
mem::drop(data)
7979
}
8080

81-
unsafe impl<'l, C: NativeClass, T: FromVariant> RawSetter<C, T> for InvalidSetter<'l> {
81+
unsafe impl<'l, C: NativeClass, T> RawSetter<C, T> for InvalidSetter<'l> {
8282
#[inline]
8383
unsafe fn into_godot_function(self) -> sys::godot_property_set_func {
8484
let mut set = sys::godot_property_set_func::default();
@@ -95,7 +95,7 @@ unsafe impl<'l, C: NativeClass, T: FromVariant> RawSetter<C, T> for InvalidSette
9595
}
9696
}
9797

98-
unsafe impl<'l, C: NativeClass, T: ToVariant> RawGetter<C, T> for InvalidGetter<'l> {
98+
unsafe impl<'l, C: NativeClass, T> RawGetter<C, T> for InvalidGetter<'l> {
9999
#[inline]
100100
unsafe fn into_godot_function(self) -> sys::godot_property_get_func {
101101
let mut get = sys::godot_property_get_func::default();

0 commit comments

Comments
 (0)