fix(DashboardChartSummary): use null for nullable values
#1631
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying beaconchain with
|
| Latest commit: |
b8d13bc
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://9e85b37f.beaconchain.pages.dev |
| Branch Preview URL: | https://beds-1548-fix-summary-chart.beaconchain.pages.dev |
enzo-bitfly
force-pushed
the
BEDS-1548/fix-summary-chart-null-values
branch
from
5487b77 to
b401f38
Compare
marcel-bitfly
force-pushed
the
BEDS-1548/fix-summary-chart-null-values
branch
from
b401f38 to
51054d1
Compare
For example for `proposal efficiency` or `sync efficiency` values can also be `null`. In the chart there should not be a value (instead of `0`) and in tooltip there shouldn't be `percentage calculation`. See: BEDS-1548
marcel-bitfly
force-pushed
the
BEDS-1548/fix-summary-chart-null-values
branch
from
51054d1 to
b8d13bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: BEDS-1548