feat(protocol): cable transport

[james-d-elliott]

This adds a remapping for the cable transport which has been observed in the wild, even though it has not been ratified and only exited for a short while before it was renamed.

[coderabbitai]

Walkthrough

The changes introduce a mapping mechanism for authenticator transport strings during attestation response parsing. A new internal map remaps legacy or unofficial transport strings, such as "cable", to their corresponding constants. The parsing logic now uses this map to ensure consistent handling of transport identifiers, without altering any public interfaces.

Changes

File(s)	Change Summary
protocol/attestation.go	Updated parsing logic for Transports to check for remapped transport strings using a new map.
protocol/const.go	Added internalRemappedAuthenticatorTransport map for remapping legacy/unofficial transport names.

Poem

In the warren of code, a new map appears,
Remapping old names, calming legacy fears.
"Cable" now hybrid, the transports align,
Rabbits rejoice, for the parsing is fine!
With each little hop, our standards grow clear—
Hooray for the changes, let’s give them a cheer! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between fec4ca1 and 64ae734.

📒 Files selected for processing (2)

• protocol/attestation.go (1 hunks)
• protocol/const.go (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (2)

protocol/const.go (1)

protocol/authenticator.go (2)

• AuthenticatorTransport (156-156)
• Hybrid (178-178)

protocol/attestation.go (1)

protocol/authenticator.go (1)

• AuthenticatorTransport (156-156)

🔇 Additional comments (2)

protocol/const.go (1)

13-21: Well-documented remapping mechanism for handling legacy transports.

This is a clean implementation of a remapping mechanism for transport values that are used in practice but didn't make it to the official recommendation. The naming convention clearly indicates this is an internal implementation detail, and the comments provide good context about the purpose and limitations of this map.

protocol/attestation.go (1)

116-121: Effective transport string remapping logic.

The implementation correctly uses the new remapping map to handle legacy transport identifiers, while maintaining backward compatibility. The code elegantly checks if a transport needs remapping, and if not, falls back to the original behavior of direct conversion.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.