Skip to content

Improve base64 comment, remove legacy go support #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Improve base64 comment, remove legacy go support #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions protocol/base64.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,8 @@ func (e *URLEncodedBase64) UnmarshalJSON(data []byte) error {
return nil
}

// TODO: Investigate this line. It is commented as trimming the leading spaces but appears to trim the leading and trailing double quotes instead.
// Trim the leading spaces.
data = bytes.Trim(data, "\"")
// Trim the leading and trailing quotes from raw JSON data (the whole value part)
data = bytes.Trim(data, `"`)

// Trim the trailing equal characters.
data = bytes.TrimRight(data, "=")
Expand Down
2 changes: 0 additions & 2 deletions protocol/webauthncose/ed25519.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
//go:build go1.13

package webauthncose

import (
Expand Down
37 changes: 0 additions & 37 deletions protocol/webauthncose/ed25519_go112.go
View file
Open in desktop

This file was deleted.

Loading