Skip to content

Remove unnecessary sync.Once #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025
Merged

Remove unnecessary sync.Once #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions dep/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import (
"os"
"os/exec"
"regexp"
"sync"
"time"

"github.com/go-tstr/tstr/strerr"
Expand Down Expand Up @@ -234,7 +233,7 @@ func WithPreCmd(cmd *exec.Cmd) Opt {
func WithGoCode(modulePath, mainPkg string) Opt {
var target string
eg := &errgroup.Group{}
eg.Go(sync.OnceValue(func() error {
eg.Go(func() error {
dir, err := os.MkdirTemp("", "go-tstr")
if err != nil {
return fmt.Errorf("failed to create tmp dir for go binary: %w", err)
Expand All @@ -251,7 +250,7 @@ func WithGoCode(modulePath, mainPkg string) Opt {
return fmt.Errorf("%w: %w", ErrBuildFailed, err)
}
return nil
}))
})

return func(c *Cmd) error {
if err := eg.Wait(); err != nil {
Expand Down