Skip to content

Improve WithGoCode build handling #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 8, 2025
Merged

Improve WithGoCode build handling #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions dep/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,11 @@ import (
"os"
"os/exec"
"regexp"
"sync"
"time"

"github.com/go-tstr/tstr/strerr"
"golang.org/x/sync/errgroup"
)

const (
Expand Down Expand Up @@ -225,16 +227,20 @@ func WithPreCmd(cmd *exec.Cmd) Opt {
}

// WithGoCode builds the given Go projects and sets the main package as the command.
// By default the command is set to collect coverage data.
// By default the the output binary is instrumented to collect coverage data
// Working directory for build command is set to modulePath which means that the mainPkg should be relative to it.
// Building the binary is done in a separate goroutine and the command is started only after the build is finished.
// Also building is done only once which allows to reuse the reusing the the same Cmd instance without rebuilding the binary.
func WithGoCode(modulePath, mainPkg string) Opt {
return func(c *Cmd) error {
var target string
eg := &errgroup.Group{}
eg.Go(sync.OnceValue(func() error {
dir, err := os.MkdirTemp("", "go-tstr")
if err != nil {
return fmt.Errorf("failed to create tmp dir for go binary: %w", err)
}

target := dir + "/" + "go-app"
target = dir + "/" + "go-app"
buildCmd := exec.Command("go", "build", "-race", "-cover", "-covermode", "atomic", "-o", target, mainPkg)
buildCmd.Env = append(os.Environ(), "CGO_ENABLED=1") // Required for -race flag
buildCmd.Stdout = os.Stdout
Expand All @@ -244,6 +250,13 @@ func WithGoCode(modulePath, mainPkg string) Opt {
if err != nil {
return fmt.Errorf("%w: %w", ErrBuildFailed, err)
}
return nil
}))

return func(c *Cmd) error {
if err := eg.Wait(); err != nil {
return err
}

c.cmd = exec.Command(target)
c.cmd.Stdout = os.Stdout
Expand Down