Update workflow.yml to support 2 most recent major versions #1417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port-2-major-go-versions
zemzale
approved these changes
Apr 30, 2025
|
We only officially support the latest two versions, but is there any reason to not test the older version as well until if starts failing? |
|
@deankarn I'm just trying to understand the reasoning - why test the older version if it's no longer officially supported? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Or Enhances
Based on the https://github.com/go-playground/validator?tab=readme-ov-file#maintenance-and-support-for-sdk-major-versions
Make sure that you've checked the boxes below before you submit PR:
@go-playground/validator-maintainers