Only hide dropzone when no files have been uploaded #35156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

bartvdbraak wants to merge 6 commits into go-gitea:main from bartvdbraak:dropzone-hidden-fix

+6 −1

bartvdbraak commented Jul 24, 2025 •

edited

Loading

Instead of always hiding the dropzone when it's not active:

hide it when when there are no uploaded files and it becomes inactive
don't hide it when there are uploaded files

Fixes #35125


          Only hide dropzone when no files have been uploaded

29d353f

GiteaBot added the lgtm/need 2 label

github-actions bot added the modifies/frontend label

techknowlogick added type/bug topic/ui backport/v1.24 labels

blender-it pushed a commit to blender/gitea that referenced this pull request


          BLENDER: Only hide dropzone when no files have been uploaded

ba0ef7d

Upstream patch at go-gitea#35156

wxiaoguang reviewed

View reviewed changes

web_src/js/features/repo-issue.ts Outdated Show resolved Hide resolved


          Replace fragile selectors with direct options from Dropzone

7e55d4d

bartvdbraak requested a review from wxiaoguang

July 25, 2025 09:58

blender-it pushed a commit to blender/gitea that referenced this pull request


          BLENDER: Only hide dropzone when no files have been uploaded

Upstream patch at go-gitea#35156

wxiaoguang reviewed

View reviewed changes

web_src/js/features/repo-issue.ts Outdated Show resolved Hide resolved

wxiaoguang reviewed

View reviewed changes

web_src/js/features/repo-issue.ts Outdated Show resolved Hide resolved

wxiaoguang added 2 commits

July 25, 2025 19:02


          Apply suggestion

7f65e6f

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>


          Apply suggestion

c606832

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

wxiaoguang reviewed

View reviewed changes

web_src/js/features/repo-issue.ts Outdated Show resolved Hide resolved


          Apply suggestion

0e949d4

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

wxiaoguang reviewed

View reviewed changes

web_src/js/features/repo-issue.ts Outdated Show resolved Hide resolved


          Apply suggestion

86e0932

Signed-off-by: wxiaoguang <wxiaoguang@gmail.com>

wxiaoguang reviewed

View reviewed changes

Contributor

wxiaoguang left a comment •

edited

Loading

Made some changes via GitHub online editor.

I think we do not need to tolerate "null/undefined" for this case: if ".form-field-dropzone" exists, then ".dropzone" must exists, then "el.dropzone" must exist. If any of them doesn't exist, there must be something (more serious) wrong.

Member

silverwind commented Jul 25, 2025 •

edited

Loading

Yeah, it's better to let the code crash than to hide bugs with ?. etc. In the first case we may get a bug report. In the second, it silently fails to work.

Author

bartvdbraak commented Jul 25, 2025

Made some changes via GitHub online editor.

I think we do not need to tolerate "null/undefined" for this case: if ".form-field-dropzone" exists, then ".dropzone" must exists, then "el.dropzone" must exist. If any of them doesn't exist, there must be something (more serious) wrong.

Are there any changes that still need to be made here?

wxiaoguang approved these changes

View reviewed changes

GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels

lunny approved these changes

View reviewed changes

GiteaBot added lgtm/done and removed lgtm/need 1 labels

delvh approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport/v1.24 lgtm/done modifies/frontend topic/ui type/bug