-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: migrate to urfave/cli v3 #2501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This comment was marked as off-topic.
This comment was marked as off-topic.
I have the feeling after playing a bit with urfave/cli v3 that not all things are stable, so we will wait a bit before the merge of this PR. |
v3.2 of urfave/cli breaks things... I always appreciated the simplicity of this lib, but the current release flow is bad, very bad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean... if upgrading urfave/cli
to v3 is this tedious, we can stay on v2 for a while longer.
Have you looked into alternatives, yet? Personally, I found spf13/pflag
sufficient most of the time, and spf13/cobra
helpful for anything beyond.
I use IMHO, I'm looking at I also created a configuration parser a few years ago: But I still like the simplicity of For now, we don't need to migrate, so we will wait. |
The migration guide is sparse https://cli.urfave.org/migrate-v2-to-v3/, but the migration is not complex.