checks for static lib #1278
Merged
checks for static lib #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanvos
reviewed
Sep 8, 2024
|
|
||
| private static final List<String> baseNativeImageArguments = Arrays.asList( | ||
| "-Djdk.internal.lambda.eagerlyInitialize=false", | ||
| "-Ddebug.jdk.graal.jvmciConfigCheck=warn", |
There was a problem hiding this comment.
shouldn't this be defined somewhere else then? (globally?)
There was a problem hiding this comment.
We didn't have this before, and it is not needed now once gluonhq/graal#20 gets merged
johanvos
approved these changes
Sep 9, 2024
jperedadnr
added a commit
to jperedadnr/substrate
that referenced
this pull request
Mar 19, 2025
This reverts commit c3bf470.
jperedadnr
added a commit
that referenced
this pull request
Mar 19, 2025
* Revert "Prepare development of 0.0.66" This reverts commit 3c6b21c. * Revert "New release: 0.0.65" This reverts commit 93edd93. * Revert "Add filter check to macOS (#1301)" This reverts commit 88d1ee3. * Revert "add zip extension (#1305)" This reverts commit a4dfa98. * Revert "Increase timeout for codesign process (#1303)" This reverts commit 20a0fbb. * Revert "Bump gradle wrapper version (#1299)" This reverts commit 0515389. * Revert "Bump JDK version (#1293)" This reverts commit f6c9687. * Revert "Add new path for provisioning profiles starting Xcode 16 (#1292)" This reverts commit 5ad754b. * Revert "Prepare development of 0.0.65" This reverts commit 6ee1f25. * Revert "New release: 0.0.64" This reverts commit 8772160. * Revert "Migrate to publish-plugin (#1287)" This reverts commit 93f3c22. * Revert "Add warnings on Windows and Linux AArch64 (#1279)" This reverts commit 33adb7a. * Revert "Bump static JDK version (#1282)" This reverts commit e7b87a4. * Revert "checks for static lib (#1278)" This reverts commit c3bf470. * Revert "Set macOS min version in plist (#1275)" This reverts commit 2851322. * Revert "macOS fixes (#1274)" This reverts commit 28e2103. * Revert "Update Substrate to use latest GraalVM (JDK 23) and JavaFX 24-ea (#1273)" This reverts commit f93489a. * Set macOS min version in plist (#1275) * Migrate to publish-plugin (#1287) * Add new path for provisioning profiles starting Xcode 16 * Bump gradle wrapper version (#1299) * Increase timeout for codesign process (#1303) * add zip extension (#1305) * Add filter check to macOS (#1301) * Add filter check to macOS * Use lipo for macOS * remove import * Prepare development of 0.0.66 * Update action * update build job * Use supported GraalVM * Add arch * bump JavaFX version for tests * bump JavaFX plugin version for tests --------- Co-authored-by: Abhinay Agarwal <abhinay.agarwal@gluonhq.com> Co-authored-by: Gluon Bot <githubbot@gluonhq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #1273, add some fixes for
staticlib(), and remove unneeded argument.