-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
feat(forms): Validation conditions for question answers #19681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
cedric-anne
merged 4 commits into
glpi-project:main
from
ccailly:feature/form-validation-conditions
May 20, 2025
Merged
feat(forms): Validation conditions for question answers #19681
cedric-anne
merged 4 commits into
glpi-project:main
from
ccailly:feature/form-validation-conditions
May 20, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9fe989f
to
b32bcc8
Compare
b32bcc8
to
b5779b2
Compare
AdrienClairembault
requested changes
May 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
978ca44
to
f738b04
Compare
f738b04
to
58e1409
Compare
AdrienClairembault
requested changes
May 14, 2025
…rove json_decode usage
trasher
reviewed
May 19, 2025
AdrienClairembault
requested changes
May 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AdrienClairembault
approved these changes
May 19, 2025
trasher
approved these changes
May 20, 2025
cedric-anne
approved these changes
May 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
templates/pages/admin/form/destination_visibility_conditions_configuration.html.twig
Show resolved
Hide resolved
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before requesting a review
Please delete options that are not relevant.
Description
#19640 must be merged before
Added validation conditions for answers to questions.
Reuse of the condition system already implemented for the visibility of form elements.
Screenshots (if appropriate):