must declare config js vars directly on window

cconard96 · cedric-anne · commit b16c9a6a4882 · 2025-05-19T09:08:34.000+02:00
diff --git a/src/Glpi/Application/View/Extension/FrontEndAssetsExtension.php b/src/Glpi/Application/View/Extension/FrontEndAssetsExtension.php
@@ -295,9 +295,9 @@ public function configJs(): string
 
         $plugins_path = \array_map(fn(string $plugin_key) => "/plugins/{$plugin_key}", Plugin::getPlugins());
 
-        $script = sprintf('const CFG_GLPI = %s;', json_encode($cfg_glpi, JSON_PRETTY_PRINT))
+        $script = sprintf('window.CFG_GLPI = %s;', json_encode($cfg_glpi, JSON_PRETTY_PRINT))
             . "\n"
-            . sprintf('const GLPI_PLUGINS_PATH = %s;', json_encode($plugins_path, JSON_PRETTY_PRINT));
+            . sprintf('window.GLPI_PLUGINS_PATH = %s;', json_encode($plugins_path, JSON_PRETTY_PRINT));
 
         return Html::scriptBlock($script);
     }

Original file line number	Diff line number	Diff line change
`@@ -295,9 +295,9 @@ public function configJs(): string`
`295`	`295`
`296`	`296`	`$plugins_path = \array_map(fn(string $plugin_key) => "/plugins/{$plugin_key}", Plugin::getPlugins());`
`297`	`297`
`298`		`- $script = sprintf('const CFG_GLPI = %s;', json_encode($cfg_glpi, JSON_PRETTY_PRINT))`
	`298`	`+ $script = sprintf('window.CFG_GLPI = %s;', json_encode($cfg_glpi, JSON_PRETTY_PRINT))`
`299`	`299`	`. "\n"`
`300`		`- . sprintf('const GLPI_PLUGINS_PATH = %s;', json_encode($plugins_path, JSON_PRETTY_PRINT));`
	`300`	`+ . sprintf('window.GLPI_PLUGINS_PATH = %s;', json_encode($plugins_path, JSON_PRETTY_PRINT));`
`301`	`301`
`302`	`302`	`return Html::scriptBlock($script);`
`303`	`303`	`}`