Fix multiple twig errors in itil side panel

Author: AdrienClairembault

phpunit/functional/ChangeTest.php

@@ -34,6 +34,7 @@
 
 namespace tests\units;
 
+use Change;
 use DbTestCase;
 
 /* Test for inc/change.class.php */
@@ -464,4 +465,20 @@ public function testCentralChangeValidationList()
         $output = ob_get_clean();
         $this->assertStringNotContainsString("Your changes to validate", $output);
     }
+
+    public function testShowFormNewItem(): void
+    {
+        // Arrange: prepare an empty change
+        $change = new Change();
+        $change->getEmpty();
+
+        // Act: render form for a new change
+        $this->login();
+        ob_start();
+        $change->showForm($change->getID());
+        $html = ob_get_clean();
+
+        // Assert: make sure some html was generated
+        $this->assertNotEmpty($html);
+    }
 }

phpunit/functional/ProblemTest.php

@@ -35,6 +35,7 @@
 namespace tests\units;
 
 use DbTestCase;
+use Problem;
 
 /* Test for inc/problem.class.php */
 
@@ -306,4 +307,20 @@ public function testSearchOptions()
         $this->assertTrue(array_key_exists('ITEM_Problem_74', $problem_with_so));
         $this->assertEquals($last_solution_date, $problem_with_so['ITEM_Problem_74']);
     }
+
+    public function testShowFormNewItem(): void
+    {
+        // Arrange: prepare an empty problem
+        $problem = new Problem();
+        $problem->getEmpty();
+
+        // Act: render form for a new problem
+        $this->login();
+        ob_start();
+        $problem->showForm($problem->getID());
+        $html = ob_get_clean();
+
+        // Assert: make sure some html was generated
+        $this->assertNotEmpty($html);
+    }
 }

templates/components/itilobject/actors/main.html.twig

@@ -66,7 +66,7 @@
          'itiltemplate': itiltemplate,
          'params': params,
          'canupdate': canupdate,
-         'cancreateuser': cancreateuser,
+         'cancreateuser': cancreateuser|default(false),
          'canassigntome': canassigntome ?? false,
          'main_rand': main_rand,
          'allow_auto_submit': allow_auto_submit,
@@ -99,7 +99,7 @@
          'itiltemplate': itiltemplate,
          'params': params,
          'canupdate': canupdate,
-         'cancreateuser': cancreateuser,
+         'cancreateuser': cancreateuser|default(false),
          'canassigntome': canassigntome ?? false,
          'main_rand': main_rand,
          'allow_auto_submit': allow_auto_submit,

templates/components/itilobject/fields_panel.html.twig

@@ -70,7 +70,9 @@
                      item.fields['entities_id'],
                      _n('Entity', 'Entities', 1),
                      field_options|merge({
-                        'entity': userentities,
+                        'entity': userentities|default(
+                           session('glpiactive_entity')
+                        ),
                         'on_change': 'this.form.submit()',
                      })
                   ) }}
@@ -196,7 +198,7 @@
             {{ include('components/itilobject/fields/status.html.twig') }}
 
             {# validation #}
-            {% if item.fields['global_validation'] != 1 %}
+            {% if item.fields['global_validation']|default(1) != 1 %}
                {{ include('components/itilobject/fields/global_validation.html.twig') }}
             {% endif %}
 
@@ -275,7 +277,7 @@
             <span class="badge bg-secondary text-secondary-fg ms-2">
                {{ item.countActors() }}
             </span>
-            {% if not (params['template_preview'] ?? false) and cancreateuser and canupdate %}
+            {% if not (params['template_preview'] ?? false) and cancreateuser|default(false) and canupdate %}
                {{ include('components/user/create_user.html.twig') }}
             {% endif %}
          </button>
@@ -287,7 +289,7 @@
       </div>
    </section>
 
-   {% if canreadnote %}
+   {% if canreadnote|default(false) %}
       {% set notes = call('Notepad::getAllForItem', [get_item('Entity', item.fields['entities_id']), 'Ticket']) %}
       {% set notes_show = headers_states['notes'] is not defined or headers_states['notes'] == "true" ? true : (notes|length > 0) %}
        {% if notes|length != 0 %}