fix: ensures support for additional Facet types (beyond 'terms') #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbottigliero
force-pushed
the
fix-facets-date_histogram
branch
2 times, most recently
from
1a220ea to
607cc7c
Compare
jbottigliero
force-pushed
the
fix-facets-date_histogram
branch
from
607cc7c to
bb3b9b7
Compare
jbottigliero
commented
Nov 11, 2024
| import type { ResultComponentOptions } from "@/components/Result"; | ||
| import { NavigationOptions } from "@/components/Navigation"; | ||
|
|
||
| import type { GFacet } from "@globus/sdk/services/search/service/query"; |
There was a problem hiding this comment.
NOTE TO SELF:
This isn't going to work based on the current type in the SDK... which I think is slightly off based on:
sizeshould be optional whentype: "terms"nameis optional and is only required if there is a conflict infield_name
Aside from that, it's not clear we're actually processing the generated GFilter properly given the configured GFacet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #251