Skip to content

Conversation

kurtmckee
Copy link
Member

Added

  • Add the statuses parameter to GroupsClient.get_my_groups().

@kurtmckee kurtmckee force-pushed the update-auth-get_my_groups branch from 711925d to afba097 Compare September 29, 2025 15:49
@sirosen
Copy link
Member

sirosen commented Sep 29, 2025

Since it's buried in CI output, let me save you a minute:

mypy-py3.8: commands[0]> mypy src/
src/globus_sdk/services/groups/client.py:12: error: Name "t.TypeAlias" is not defined  [name-defined]
Found 1 error in 1 file (checked 338 source files)

We should fix / move off of supporting 3.8, sort of a separate matter from other things we're holding.

@kurtmckee kurtmckee force-pushed the update-auth-get_my_groups branch from afba097 to deac5b4 Compare September 29, 2025 15:58
@kurtmckee
Copy link
Member Author

Thanks! Fix is posted.

We should likely be testing mypy against all supported Python versions, which is a lesson I learned the hard way in another OSS repo recently.

@kurtmckee kurtmckee merged commit 46a0933 into main Sep 29, 2025
7 checks passed
@kurtmckee kurtmckee deleted the update-auth-get_my_groups branch September 29, 2025 16:11
kurtmckee added a commit that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants