Add support for Search's Index Update API #1310
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
kurtmckee
requested changes
Sep 17, 2025
Comment on lines
109
to
110
| "History and Witchcraft", | ||
| "Searchable information about history and witchcraft", |
There was a problem hiding this comment.
I'd like to suggest something that doesn't involve witchcraft.
There was a problem hiding this comment.
I'm not sure why this particular set of values is worth flagging. But I have no attachment to these and don't see them as any kind of statement. I'll change it to something else.
For future reference, I would prefer that any requests for cosmetic changes include specific change requests, i.e. "remove this line" or "use this instead". When it's low-stakes, it's much easier (cognitive overhead-wise) to apply a suggestion than it is to try to guess why the previous value was not acceptable.
The SDK method is named `update_index` to be consistent with other methods like `create_index` and `delete_index`. Some of the test data and Search docs reveal that service-side, this is being called "index_update" in some cases. Weighing the pro/con around this discrepancy, consistency with other SDK methods seems more important than matching the exact string used by the service in some cases.
sirosen
force-pushed
the
support-search-index-patch
branch
from
f6af0ab to
64fffef
Compare
kurtmckee
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SDK method is named
update_indexto be consistent with othermethods like
create_indexanddelete_index. Some of the test dataand Search docs reveal that service-side, this is being called
"index_update" in some cases. Weighing the pro/con around this
discrepancy, consistency with other SDK methods seems more important than
matching the exact string used by the service in some cases.