Clean up symlinks from transfer_data.py #1307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaschaer
requested review from
MaxTueckeGlobus,
ada-globus,
derek-globus,
kurtmckee,
m1yag1 and
sirosen
as code owners
aaschaer
force-pushed
the
aaron/symlink_deprecation
branch
from
3aa3f2c to
9ff09b1
Compare
…and update docstring
aaschaer
force-pushed
the
aaron/symlink_deprecation
branch
from
9ff09b1 to
6e66616
Compare
sirosen
reviewed
Sep 16, 2025
Co-authored-by: Stephen Rosen <sirosen@globus.org>
sirosen
approved these changes
Sep 16, 2025
sirosen
added a commit
to sirosen/globus-sdk-python
that referenced
this pull request
Sep 17, 2025
This takes the latest 3.x development work (`main`) and merges it into 4.x development (`4.x-dev`). In particular, this changeset takes globus#1307 and globus#1308 and applies them against 4.x. The following changes are made in order to resolve merge conflicts and produce a good result: - the deprecated method and parameter from globus#1307 are removed - the deprecated parameters from globus#1308 are removed - tests for deprecated behaviors are removed - the relevant changelogs are removed from the `changelog.d/` directory - a new changelog.d/ fragment is added to describe the removals
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transfer_data.pywas missed when cleaning up references to symlinks, which are not supported by any collections.Updates docstring and adds deprecation warnings accordingly.