-
Notifications
You must be signed in to change notification settings - Fork 44
Merge main into 4.x-dev #1306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge main into 4.x-dev #1306
Conversation
Remove the '_id' suffix, per discussion with the Groups team. The new name is 'set_subscription_admin_verified'. The old function is still available as an alias, but emits a `RemovedInV4Warning`. The test fixture data in `globus_sdk._testing` is slightly adjusted, but not considered a breaking change due to the looser compatibility policy around the provided fixtures.
This build now fails for us with a message about action version pinning (presumably because we have enabled the requirement for hash versioning). Checking up on the action repo, it currently has a deprecation notice. After enabling PR builds via their new integration (a GitHub App), I am removing this build. We should continue to get PR builds, and if we do not we can investigate without "noise" from this failing build.
Bumps the github-actions group with 1 update: [actions/checkout](https://github.com/actions/checkout). Updates `actions/checkout` from 4.2.2 to 5.0.0 - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](actions/checkout@11bd719...08c6903) --- updated-dependencies: - dependency-name: actions/checkout dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: github-actions ... Signed-off-by: dependabot[bot] <support@github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if that pylint ignore was added here or previously, but I don't remember it being necessary. Suggests that something hinky is going on. I'll try to remember to look at it, but also... 🤷
I added it here. |
Merging latest changes from main branch into 4.x-dev
📚 Documentation preview 📚: https://globus-sdk-python--1306.org.readthedocs.build/en/1306/