gh-629: temporarily pin array-api-strict
#632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paddyroddy
added
bug
Saransh-cpp
approved these changes
Jul 8, 2025
ntessore
approved these changes
Jul 8, 2025
pyproject.toml
Outdated
| @@ -60,7 +60,7 @@ examples = [ | |||
| "matplotlib", | |||
| ] | |||
| test = [ | |||
| "array_api_strict>=2", | |||
| "array_api_strict<2.4", | |||
There was a problem hiding this comment.
Do we not want to keep the >=2 if there was a reason to have it? If not then good to go from me
There was a problem hiding this comment.
If someone were to install it, then it would install 2.3.1. @Saransh-cpp you implemented that bound. Do you feel strongly?
There was a problem hiding this comment.
Ah, I just realised why I did this. We use the api_version flag to adhere to a specific array API version -
Line 72 in 4349efe
and this flag was introduced in 2.0.0, so yes, we should keep >=2.
Saransh-cpp
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A recent change (see #629) is causing the tests to fail. Following this suggestion idea data-apis/array-api-extra#343 (comment) and not wanting to drop
Python<3.12this is a compromise.Checks