feat: new optional OAuth2 configuration for the Reddit widget #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s0ders
force-pushed
the
main
branch
2 times, most recently
from
8870b1f to
dfc52a0
Compare
|
Eagerly waiting for this one to be merged! can't view my subreddit updates without it :( |
This commit brings the following: - New `reddit-app-name`, `reddit-client-id` and `reddit-client-secret` optional configurations for the Reddit widget to authenticate requests sent to the Reddit API (avoiding being blocked when Glance is self-hosted) - Refactoring the of `fetchSubredditPosts` function which is now a method of `redditWidget` since it's unexported and only uses parameters which are fields of the `redditWidget` struct. ref: glanceapp#509
|
@svilenmarkov please review this. Thanks |
s0ders
changed the title
svilenmarkov
added a commit
that referenced
this pull request
Apr 28, 2025
Co-authored-by: s0ders <39492740+s0ders@users.noreply.github.com>
|
I wasn't able to make changes to the PR since you've disabled edit access for maintainers, so I used your changes, made some tweaks and committed them to the dev branch, adding you as the co-author. Thanks for contributing! |
|
My bad, I didn't check that I disabled edit access. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the following:
reddit-app-name,reddit-client-idandreddit-client-secretoptional configurations for the Reddit widget to authenticate requests sent to the Reddit API (avoiding being blocked when Glance is self-hosted)fetchSubredditPostsfunction which is now a method ofredditWidgetsince it's unexported and only uses parameters which are fields of theredditWidgetstruct.ref: #509