Remove duplicate enum #4085
Merged
Remove duplicate enum #4085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR consolidates duplicate enum definitions by removing a redundant SortOrder enum and importing it from a single source instead. The change eliminates code duplication where the same enum was defined identically in two different files.
- Remove duplicate
SortOrderenum definition fromquery-history-manager.ts - Import
SortOrderfromhistory-tree-data-provider.tswhere it's already defined
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
tuan-nguen
approved these changes
Jul 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does anyone know why we have these two identical enums? It doesn't look like either of them are used outside of
query-history-manager.tsandhistory-tree-data-provider.ts, and as far as I can tell it's not about having separate types for data storage.I came across this as part of #4056 but thought I'd pull this out to a separate PR.