build: Build-metadata usage via go:embed #689
Open
+146
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor build metadata injection logic: - Introduced `build_info` package to manage version, commit, and date details. - Removed ldflags-based metadata injection. - Updated workflows and Dockerfile to prepare `build_info` files. - Added unit tests for `build_info` initialization and formatting. Because: Since build-metadata no longer needs compiling to binary, this information can already be defined at the source code level. Related github#630
- Extracted `build_info` preparation logic to `script/prepare-build-info`. - Updated Dockerfile and GitHub workflows to use the new script. - Simplified metadata injection process for better reusability.
- Replaced direct file paths with relative command paths in scripts and config files for consistency. - Enhanced build info generation with improved handling of commit and branch information. - Updated `.gitignore` to include dynamic build info files. - Enabled write access in Dockerfile bind mount to align with changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor build metadata injection logic:
build_infopackage to manage version, commit, and date details.build_infofiles.build_infoinitialization and formatting.Because: Since build-metadata no longer needs compiling to binary, this information can already be defined at the source code level.
Related feat: enable go run execution by moving main to root #630