Skip to content

Update README.md #38538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update README.md #38538

wants to merge 1 commit into from

Conversation

lokhandemm
Copy link

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • A subject matter expert (SME) has reviewed the technical accuracy of the content in this PR. In most cases, the author can be the SME. Open source contributions may require an SME review from GitHub staff.
  • The changes in this PR meet the docs fundamentals that are required for all content.
  • All CI checks are passing and the changes look good in the review environment.

Copy link

welcome bot commented May 26, 2025

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

Copy link
Contributor

How to review these changes 👓

Thank you for your contribution. To review these changes, choose one of the following options:

A Hubber will need to deploy your changes internally to review.

Table of review links

Note: Please update the URL for your staging server or codespace.

This pull request contains code changes, so we will not generate a table of review links.

🤖 This comment is automatically generated.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label May 26, 2025
@Sharra-writes
Copy link
Contributor

@lokhandemm Hi, thanks for opening a PR! Could you refrain from @ people who aren't already part of a conversation, unless you know them and have already discussed collaborating with them? It looks like whoever @maintainer is, they aren't associated with GitHub, and it's annoying to get spam totally unrelated to you and your organization. Even if they were part of GitHub, we check this repo regularly and have a system for getting things reviewed. Calling in specific people doesn't help, it just distracts them from other tasks that need to be done.

That said, I'm not sure why you're adding a single space to a line. Can you tell me what you're trying to do?

@lokhandemm
Copy link
Author

@Sharra-writes Hello! Actually i didn't know who reviews this thing so by "maintainer" i actually meant who so ever maintains this repo! i am sorry for any unintentional inconvenience caused by me!
Also the reason for adding just a space was that, it is my first time creating a pull up request so i was learning to do so.
I hope you don't mind! Would appreciate if you grant me the review!
Thank you.

@lokhandemm
Copy link
Author

@Sharra-writes I deleted my comments just in case they caused some trouble!

@Sharra-writes
Copy link
Contributor

Sharra-writes commented May 27, 2025

@lokhandemm Ah, okay. Thank you for doing that. 💛 We don't review things in this repo just to review them, especially someone like me with write access, since that would open up the door to having the pull request merged. This is a great place to contribute if you come across a typo in the docs, or something that could be phrased more clearly, or, if you happen to have expertise in coding, we usually have open issues with a help wanted label that need someone knowledgeable to make an update to the docs. If you just want to practice the basics, though, we have an entire Skills repository that can help with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Do not begin working on this issue until triaged by the team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants