Skip to content

Commit 9371737

Browse files
authored
Merge pull request #6894 from igfoo/igfoo/exprs
Java: Don't use dbscheme tables in CloseType.qll
2 parents 5216bba + 54d2028 commit 9371737

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

java/ql/src/Likely Bugs/Resource Leaks/CloseType.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,8 +228,8 @@ private predicate closeCalled(Variable v) {
228228
)
229229
or
230230
// The "close" call could happen indirectly inside a helper method of unknown name.
231-
exists(int i | exprs(v.getAnAccess(), _, _, e, i) |
232-
exists(Parameter p, int j | params(p, _, j, e.getMethod(), _) |
231+
exists(int i | e.getArgument(i) = v.getAnAccess() |
232+
exists(Parameter p, int j | p.getPosition() = j and p.getCallable() = e.getMethod() |
233233
closeCalled(p) and i = j
234234
or
235235
// The helper method could be iterating over a varargs parameter.

0 commit comments

Comments
 (0)