Update java/ql/src/Likely Bugs/Resource Leaks/CloseType.qll

igfoo · smowton · web-flow · commit 54d202892010 · 2021-10-18T10:12:01.000+01:00
Co-authored-by: Chris Smowton &lt;smowton@github.com&gt;
diff --git a/java/ql/src/Likely Bugs/Resource Leaks/CloseType.qll b/java/ql/src/Likely Bugs/Resource Leaks/CloseType.qll
@@ -228,7 +228,7 @@ private predicate closeCalled(Variable v) {
     )
     or
     // The "close" call could happen indirectly inside a helper method of unknown name.
-    exists(int i | v.getAnAccess().isNthChildOf(e, i) |
+    exists(int i | e.getArgument(i) = v.getAnAccess() |
       exists(Parameter p, int j | p.getPosition() = j and p.getCallable() = e.getMethod() |
         closeCalled(p) and i = j
         or

Original file line number	Diff line number	Diff line change
`@@ -228,7 +228,7 @@ private predicate closeCalled(Variable v) {`
`228`	`228`	`)`
`229`	`229`	`or`
`230`	`230`	`// The "close" call could happen indirectly inside a helper method of unknown name.`
`231`		`- exists(int i \| v.getAnAccess().isNthChildOf(e, i) \|`
	`231`	`+ exists(int i \| e.getArgument(i) = v.getAnAccess() \|`
`232`	`232`	`exists(Parameter p, int j \| p.getPosition() = j and p.getCallable() = e.getMethod() \|`
`233`	`233`	`closeCalled(p) and i = j`
`234`	`234`	`or`