explicitly import required frameworks that were previously implicitly imported

Author: erik-krogh

java/ql/lib/semmle/code/java/security/AndroidIntentRedirectionQuery.qll

@@ -6,6 +6,7 @@ import semmle.code.java.dataflow.DataFlow2
 import semmle.code.java.dataflow.TaintTracking
 import semmle.code.java.dataflow.TaintTracking3
 import semmle.code.java.security.AndroidIntentRedirection
+private import semmle.code.java.frameworks.android.Intent
 
 /**
  * A taint tracking configuration for tainted Intents being used to start Android components.

java/ql/src/experimental/Security/CWE/CWE-036/OpenStream.ql

@@ -15,6 +15,7 @@ import semmle.code.java.dataflow.TaintTracking
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.dataflow.ExternalFlow
 import DataFlow::PathGraph
+private import semmle.code.java.frameworks.Networking
 
 class UrlConstructor extends ClassInstanceExpr {
   UrlConstructor() { this.getConstructor().getDeclaringType() instanceof TypeUrl }

java/ql/src/experimental/Security/CWE/CWE-073/JFinalController.qll

@@ -1,6 +1,7 @@
 import java
 private import semmle.code.java.dataflow.ExternalFlow
 private import semmle.code.java.dataflow.FlowSources
+private import semmle.code.java.dataflow.FlowSteps
 
 /** The class `com.jfinal.core.Controller`. */
 class JFinalController extends RefType {

java/ql/src/experimental/Security/CWE/CWE-094/SpringImplicitViewManipulation.ql

@@ -11,6 +11,7 @@
 
 import java
 import SpringViewManipulationLib
+private import semmle.code.java.frameworks.Servlets
 
 private predicate canResultInImplicitViewConversion(Method m) {
   m.getReturnType() instanceof VoidType

java/ql/src/experimental/Security/CWE/CWE-094/SpringViewManipulationLib.qll

@@ -7,6 +7,7 @@ import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.dataflow.TaintTracking
 import semmle.code.java.frameworks.spring.Spring
 import SpringFrameworkLib
+private import semmle.code.xml.MavenPom
 
 /** Holds if `Thymeleaf` templating engine is used in the project. */
 predicate thymeleafIsUsed() {

java/ql/src/experimental/Security/CWE/CWE-200/AndroidFileIntentSource.qll

@@ -4,6 +4,7 @@ import java
 import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.dataflow.TaintTracking2
 import semmle.code.java.frameworks.android.Android
+private import semmle.code.java.frameworks.android.Intent
 
 /** The `startActivityForResult` method of Android's `Activity` class. */
 class StartActivityForResultMethod extends Method {

java/ql/src/experimental/Security/CWE/CWE-346/UnvalidatedCors.ql

@@ -15,6 +15,8 @@ import semmle.code.java.frameworks.Servlets
 import semmle.code.java.dataflow.TaintTracking
 import semmle.code.java.dataflow.TaintTracking2
 import DataFlow::PathGraph
+private import semmle.code.java.Collections
+private import semmle.code.java.Maps
 
 /**
  *  Holds if `header` sets `Access-Control-Allow-Credentials` to `true`. This ensures fair chances of exploitability.

java/ql/src/experimental/Security/CWE/CWE-552/UnsafeUrlForward.ql

@@ -17,6 +17,7 @@ import semmle.code.java.dataflow.TaintTracking
 import experimental.semmle.code.java.frameworks.Jsf
 import experimental.semmle.code.java.PathSanitizer
 import DataFlow::PathGraph
+private import semmle.code.java.frameworks.Servlets
 
 class UnsafeUrlForwardFlowConfig extends TaintTracking::Configuration {
   UnsafeUrlForwardFlowConfig() { this = "UnsafeUrlForwardFlowConfig" }

java/ql/src/experimental/Security/CWE/CWE-552/UnsafeUrlForward.qll

@@ -4,6 +4,9 @@ private import semmle.code.java.dataflow.ExternalFlow
 private import semmle.code.java.dataflow.FlowSources
 private import semmle.code.java.dataflow.StringPrefixes
 private import semmle.code.java.frameworks.javaee.ejb.EJBRestrictions
+private import semmle.code.java.frameworks.Servlets
+private import semmle.code.java.frameworks.spring.SpringWeb
+private import semmle.code.java.frameworks.spring.SpringController
 
 /** A sink for unsafe URL forward vulnerabilities. */
 abstract class UnsafeUrlForwardSink extends DataFlow::Node { }

java/ql/src/experimental/Security/CWE/CWE-598/SensitiveGetQuery.ql

@@ -14,6 +14,7 @@ import semmle.code.java.dataflow.FlowSources
 import semmle.code.java.dataflow.TaintTracking
 import semmle.code.java.security.SensitiveActions
 import DataFlow::PathGraph
+private import semmle.code.java.frameworks.Servlets
 
 /** A variable that holds sensitive information judging by its name. */
 class SensitiveInfoExpr extends Expr {