Skip to content

Commit 14d83ab

Browse files
committed
make the framework imports in FlowSources.qll private
1 parent 8066e39 commit 14d83ab

File tree

5 files changed

+26
-25
lines changed

5 files changed

+26
-25
lines changed

java/ql/lib/semmle/code/java/dataflow/FlowSources.qll

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,28 @@ import java
66
import semmle.code.java.dataflow.DataFlow
77
import semmle.code.java.dataflow.TaintTracking
88
import semmle.code.java.dataflow.DefUse
9-
import semmle.code.java.frameworks.Jdbc
10-
import semmle.code.java.frameworks.Networking
11-
import semmle.code.java.frameworks.Properties
12-
import semmle.code.java.frameworks.Rmi
13-
import semmle.code.java.frameworks.Servlets
14-
import semmle.code.java.frameworks.ApacheHttp
15-
import semmle.code.java.frameworks.android.XmlParsing
16-
import semmle.code.java.frameworks.android.WebView
17-
import semmle.code.java.frameworks.JaxWS
18-
import semmle.code.java.frameworks.javase.WebSocket
19-
import semmle.code.java.frameworks.android.Android
20-
import semmle.code.java.frameworks.android.ExternalStorage
21-
import semmle.code.java.frameworks.android.OnActivityResultSource
22-
import semmle.code.java.frameworks.android.Intent
23-
import semmle.code.java.frameworks.play.Play
24-
import semmle.code.java.frameworks.spring.SpringWeb
25-
import semmle.code.java.frameworks.spring.SpringController
26-
import semmle.code.java.frameworks.spring.SpringWebClient
27-
import semmle.code.java.frameworks.Guice
28-
import semmle.code.java.frameworks.struts.StrutsActions
29-
import semmle.code.java.frameworks.Thrift
30-
import semmle.code.java.frameworks.javaee.jsf.JSFRenderer
9+
private import semmle.code.java.frameworks.Jdbc
10+
private import semmle.code.java.frameworks.Networking
11+
private import semmle.code.java.frameworks.Properties
12+
private import semmle.code.java.frameworks.Rmi
13+
private import semmle.code.java.frameworks.Servlets
14+
private import semmle.code.java.frameworks.ApacheHttp
15+
private import semmle.code.java.frameworks.android.XmlParsing
16+
private import semmle.code.java.frameworks.android.WebView
17+
private import semmle.code.java.frameworks.JaxWS
18+
private import semmle.code.java.frameworks.javase.WebSocket
19+
private import semmle.code.java.frameworks.android.Android
20+
private import semmle.code.java.frameworks.android.ExternalStorage
21+
private import semmle.code.java.frameworks.android.OnActivityResultSource
22+
private import semmle.code.java.frameworks.android.Intent
23+
private import semmle.code.java.frameworks.play.Play
24+
private import semmle.code.java.frameworks.spring.SpringWeb
25+
private import semmle.code.java.frameworks.spring.SpringController
26+
private import semmle.code.java.frameworks.spring.SpringWebClient
27+
private import semmle.code.java.frameworks.Guice
28+
private import semmle.code.java.frameworks.struts.StrutsActions
29+
private import semmle.code.java.frameworks.Thrift
30+
private import semmle.code.java.frameworks.javaee.jsf.JSFRenderer
3131
private import semmle.code.java.dataflow.ExternalFlow
3232

3333
/** A data flow source of remote user input. */

java/ql/lib/semmle/code/java/frameworks/android/Widget.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import java
44
private import semmle.code.java.dataflow.ExternalFlow
55
private import semmle.code.java.dataflow.FlowSources
6+
private import semmle.code.java.dataflow.FlowSteps
67

78
private class AndroidWidgetSourceModels extends SourceModelCsv {
89
override predicate row(string row) {

java/ql/lib/semmle/code/java/security/ResponseSplitting.qll

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,8 @@
33
import java
44
import semmle.code.java.dataflow.DataFlow
55
import semmle.code.java.dataflow.FlowSources
6-
import semmle.code.java.frameworks.Servlets
7-
import semmle.code.java.frameworks.JaxWS
86
private import semmle.code.java.dataflow.ExternalFlow
7+
private import semmle.code.java.frameworks.Servlets
98

109
/** A sink that is vulnerable to an HTTP header splitting attack. */
1110
abstract class HeaderSplittingSink extends DataFlow::Node { }

java/ql/src/experimental/Security/CWE/CWE-089/MyBatisCommonLib.qll

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ import semmle.code.xml.MyBatisMapperXML
77
import semmle.code.java.dataflow.FlowSources
88
import semmle.code.java.frameworks.MyBatis
99
import semmle.code.java.frameworks.Properties
10+
private import semmle.code.java.Maps
1011

1112
private predicate propertiesKey(DataFlow::Node prop, string key) {
1213
exists(MethodAccess m |

java/ql/src/experimental/Security/CWE/CWE-601/SpringUrlRedirect.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import DataFlow
33
import semmle.code.java.dataflow.FlowSources
44
import semmle.code.java.dataflow.DataFlow2
55
import semmle.code.java.dataflow.TaintTracking
6-
import semmle.code.java.frameworks.spring.SpringController
6+
private import semmle.code.java.frameworks.spring.SpringController
77

88
/**
99
* A concatenate expression using the string `redirect:` or `ajaxredirect:` or `forward:` on the left.

0 commit comments

Comments
 (0)