Skip to content

Add .timer & various other systemd extensions (fixes #7161) #7163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vorburger
Copy link
Contributor

@vorburger vorburger commented Dec 14, 2024

Description

Fixes #7161.

Checklist:

How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)

PS: Please note this analysis for which extensions I have opted NOT to include.

@vorburger vorburger marked this pull request as ready for review December 14, 2024 14:05
@vorburger vorburger requested a review from a team as a code owner December 14, 2024 14:05
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)

It is. They're used to train the classifier.

Also every filename and extension needs to meet our usage requirements. One lesser used file or extension will hold up the PR until it meets the usage requirements.

@vorburger
Copy link
Contributor Author

How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)

It is. They're used to train the classifier.

ACK, thanks; I'll add samples.

Also every filename and extension needs to meet our usage requirements. One lesser used file or extension will hold up the PR until it meets the usage requirements.

Do you prefer separate small PRs - one for each?

@lildude
Copy link
Member

lildude commented Dec 19, 2024

Do you prefer separate small PRs - one for each?

One PR is fine, and be sure to only include extensions that meet our usage requirements as the PR will be held up waiting for any that don't meet our requirements.

@vorburger
Copy link
Contributor Author

We def don't need the comments

Inline comments now removed.

and only really want files and extensions which meet our usage requirements

These do, do the best of my understanding of your criteria, and knowledge. If I misunderstood, let me know, and I'll remove.

See #7161 (comment) for which extensions I have opted NOT to include.

along with a sample of each

Samples now added.

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the usage for each of these new files and extensions and add searches for the filenames.

A quick look at several of your results indicates a lot of these don't meet our usage requirements as repos can reasonably be expected to have more than one of them, which means the number of files criteria needs to be met. Some of the filenames you're adding only have single digit results.

Please address the test failures.

I have included a real-world usage sample for all extensions added in this PR:

* Sample source(s):
  * [URL to each sample source, if applicable]
* Sample license(s):

This needs to be filled in for every sample.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing additional extensions for systemd INI format style files
3 participants