-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Add .timer
& various other systemd extensions (fixes #7161)
#7163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)
It is. They're used to train the classifier.
Also every filename and extension needs to meet our usage requirements. One lesser used file or extension will hold up the PR until it meets the usage requirements.
ACK, thanks; I'll add samples.
Do you prefer separate small PRs - one for each? |
One PR is fine, and be sure to only include extensions that meet our usage requirements as the PR will be held up waiting for any that don't meet our requirements. |
Inline comments now removed.
These do, do the best of my understanding of your criteria, and knowledge. If I misunderstood, let me know, and I'll remove. See #7161 (comment) for which extensions I have opted NOT to include.
Samples now added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the usage for each of these new files and extensions and add searches for the filenames.
A quick look at several of your results indicates a lot of these don't meet our usage requirements as repos can reasonably be expected to have more than one of them, which means the number of files criteria needs to be met. Some of the filenames you're adding only have single digit results.
Please address the test failures.
I have included a real-world usage sample for all extensions added in this PR:
* Sample source(s): * [URL to each sample source, if applicable] * Sample license(s):
This needs to be filled in for every sample.
Description
Fixes #7161.
Checklist:
How strictly does this project require "including a real-world usage sample for all extensions added in this PR"? I sure could copy/paste a random example from those "Search results for each extension" linked above, but... what's the point of that? (I'm happy to do so, if it's required to merge this, of course; just wasn't sure if really was a hard-requirement.)
PS: Please note this analysis for which extensions I have opted NOT to include.