Skip to content

update attestations #3784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2025
Merged

update attestations #3784

merged 1 commit into from
Mar 24, 2025

Conversation

0xKurt
Copy link
Contributor

@0xKurt 0xKurt commented Mar 21, 2025

Fixes: #issue

Description

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@0xKurt 0xKurt requested review from a team as code owners March 21, 2025 13:38
@vercel Vercel
Copy link

vercel bot commented Mar 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:03pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:03pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:03pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:03pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:03pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 24, 2025 1:03pm

@0xKurt 0xKurt marked this pull request as draft March 21, 2025 13:39
hussedev
hussedev reviewed Mar 24, 2025
View reviewed changes
Copy link
Contributor

@hussedev hussedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest having the url's as env values, specially in this case that we are using a preview deployment url

@0xKurt 0xKurt force-pushed the update-attestations branch from d970d14 to 80bfc2d Compare March 24, 2025 12:19
@0xKurt
update attestations
7c95cf0 
update attestation url

update attestation

fixes

url to env
@0xKurt 0xKurt force-pushed the update-attestations branch from 80bfc2d to 7c95cf0 Compare March 24, 2025 12:20
@0xKurt 0xKurt marked this pull request as ready for review March 24, 2025 13:00
@0xKurt 0xKurt requested a review from hussedev March 24, 2025 13:02
hussedev
hussedev approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@hussedev hussedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice job!

@hussedev hussedev merged commit 7269de2 into main Mar 24, 2025
14 checks passed
@hussedev hussedev deleted the update-attestations branch March 24, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussedev hussedev hussedev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xKurt @hussedev