Skip to content

Passport scorer API update #3776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 12, 2025
Merged

Passport scorer API update #3776

merged 2 commits into from
Mar 12, 2025

Conversation

MasterHW
Copy link
Contributor

Fixes: issue

Description

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@MasterHW MasterHW requested review from a team as code owners February 28, 2025 19:09
@linear Linear
Copy link

linear bot commented Feb 28, 2025

PAR-911 Passport score CORS error

@vercel Vercel
Copy link

vercel bot commented Feb 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:41pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:41pm
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:41pm
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:41pm
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:41pm
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 7:41pm

@MasterHW
Copy link
Contributor Author

note: CORS error persisting

@MasterHW
Copy link
Contributor Author

note: CORS error persisting

fixed! thanks passport team

nijoe1
nijoe1 approved these changes Mar 12, 2025
View reviewed changes
Copy link
Contributor

@nijoe1 nijoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nijoe1 nijoe1 merged commit 08b3427 into main Mar 12, 2025
15 of 16 checks passed
@nijoe1 nijoe1 deleted the par-911-passport-score-cors-error branch March 12, 2025 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nijoe1 nijoe1 nijoe1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MasterHW @nijoe1