fix: ensure token address is lowercased #3439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bhargavaparoksham
approved these changes
May 15, 2024
codenamejason
approved these changes
May 15, 2024
debuggingfuture
pushed a commit
to 0xl10n/grants-stack
that referenced
this pull request
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, in production when you edit a round -> we try to find the decimals of the token and default it to 18 if it is undefined. It was being set to undefined and we were comparing checksum token address with lower token address which would always return fail (eg: aa == AA)
When creating a round with USDC which has 6 decimals -> the compare would fail and it would default to 18 decimals
Fix Tested on round http://localhost:3000/#/round/0x6f008d6701daf4ab585202e95c273d4225a0bf15
This was a round created with 1 USDC as match amount and then updated to 10 USDC
fixes #3421