Skip to content

fix payouts for v2 #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 14, 2024
Merged

fix payouts for v2 #3437

merged 2 commits into from
May 14, 2024

Conversation

boudra
Copy link
Contributor

@boudra boudra commented May 14, 2024 •
edited by thelostone-mc
Loading

Fixes: #3434

Description

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@boudra boudra requested review from a team as code owners May 14, 2024 13:34
@vercel Vercel
Copy link

vercel bot commented May 14, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:49pm
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 1:49pm
explorer 🛑 Canceled (Inspect) May 14, 2024 1:49pm
explorer-staging 🛑 Canceled (Inspect) May 14, 2024 1:49pm
manager 🛑 Canceled (Inspect) May 14, 2024 1:49pm
manager-staging 🛑 Canceled (Inspect) May 14, 2024 1:49pm

@boudra boudra changed the title fix payouts for v1 and v2 fix payouts for v2 May 14, 2024
@boudra boudra merged commit da95485 into main May 14, 2024
14 checks passed
@boudra boudra deleted the fix-payouts branch May 14, 2024 14:17
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
@boudra @debuggingfuture
fix payouts for v2 (gitcoinco#3437)
fa0eb04 
* fix payouts for v1 and v2

* update params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@bhargavaparoksham bhargavaparoksham bhargavaparoksham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot distribute funds
3 participants
@boudra @thelostone-mc @bhargavaparoksham