Skip to content

add a Manage Team section to Round Details page #3427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
May 16, 2024
Merged

add a Manage Team section to Round Details page #3427

merged 8 commits into from
May 16, 2024

Conversation

bhargavaparoksham
Copy link
Contributor

@bhargavaparoksham bhargavaparoksham commented May 9, 2024 •
edited
Loading

Fixes: #2727
Fixes: #2733

Description

  1. Add a "Manage Team" section to Round Details page on Manager
  2. View team members as an operator

Checklist

This PR:

  • Does it add new payout or donation token? In this case, have they been added to the indexer to avoid it to crash?
  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't disable eslint rules.
  • Doesn't work around the type checker (including but not limited to: type casts, non-null assertions, @ts-ignore, unjustified optional values).
  • Doesn't contain commented out code.
  • If adding/updating a feature, it adds/updates its test script on Notion.

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder 🛑 Canceled (Inspect) May 16, 2024 0:47am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 0:47am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 0:47am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 0:47am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 0:47am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 0:47am

@bhargavaparoksham bhargavaparoksham requested a review from a team as a code owner May 14, 2024 12:45
melissa-neira
melissa-neira reviewed May 14, 2024
View reviewed changes
Copy link
Contributor

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bhargavaparoksham question - it's a little weird to see myself listed twice here
Screenshot 2024-05-14 at 18 13 12
shouldn't I be listed just once here? as admins are inherently operators as well?

@thelostone-mc
Copy link
Contributor

shouldn't I be listed just once here? as admins are inherently operators as well?

Yup

melissa-neira
melissa-neira approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@melissa-neira melissa-neira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@bhargavaparoksham bhargavaparoksham merged commit 95493f6 into main May 16, 2024
14 checks passed
@bhargavaparoksham bhargavaparoksham deleted the manager-2727 branch May 16, 2024 12:56
debuggingfuture pushed a commit to 0xl10n/grants-stack that referenced this pull request May 19, 2024
@bhargavaparoksham @debuggingfuture
add a Manage Team section to Round Details page (gitcoinco#3427)
dede628 
* feat: add manage team tab in round view

* feat: update ViewManageTeam

* feat: update round type

* feat: add team table

* fix: alignment

* feat: fetch ens names & update tests

* chore: rm console log

* feat: filter roles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thelostone-mc thelostone-mc thelostone-mc approved these changes

@melissa-neira melissa-neira melissa-neira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Manager: Viewing team members as an operator Manager: add a "Manage Team" section to Round Details page
3 participants
@bhargavaparoksham @thelostone-mc @melissa-neira