Update UTC time to local time #3331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed UI UTC references to reflect local timezone, per ticket https://github.com/orgs/gitcoinco/projects/13/views/23?filterQuery=time&pane=issue&itemId=29281048
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bhargavaparoksham
approved these changes
May 14, 2024
debuggingfuture
pushed a commit
to 0xl10n/grants-stack
that referenced
this pull request
May 19, 2024
* update UTC references to local timezone * actually fixed test case * update UTC references to local timezone * remove commented code * convert round creator to local time * restore explicit timeformat * converted UTC references to local on settings page * specify timezone when creating rounds * fix errant unix stamp displaying * improve getTimezoneName * change over explorer timezones * timezone names across all locales * fix dependencies ---------
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #issue
Only UTC time shown in UI (mainly Round Manager) Grants Lab (view)
Description
Adds function to retrieve local timezone shorthand (e.g. "EDT"), and adds it to local-determined time in a way that as closely mirrors the existing UTC approach as possible. Did not remove existing UTC methods, only replaced their references in the UI and testcase.
Checklist
This PR:
@ts-ignore, unjustified optional values).