Skip to content

Update bito-cra.properties #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 13, 2025
Merged

Update bito-cra.properties #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ca45cdc
Update bito-cra.properties
thejeshwar-reddy-yerasi-bito Apr 8, 2025
3d63623
Update bito-cra.ps1
thejeshwar-reddy-yerasi-bito Apr 8, 2025
9c6f34f
Update bito-cra.sh
thejeshwar-reddy-yerasi-bito Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cra-scripts/bito-cra.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ dependency_check.snyk_auth_token=
review_comments=2
server_port=10051
cra_version=latest
include_branches=
include_source_branches=
include_target_branches=
exclude_files=*.xml,*.json,*.properties,.gitignore,*.yml,*.md
exclude_draft_pr=True
14 changes: 9 additions & 5 deletions cra-scripts/bito-cra.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,8 @@ $optional_params_cli = @(
"review_scope",
"enable_default_branch",
"exclude_branches",
"include_branches",
"include_source_branches",
"include_target_branches",
"exclude_files",
"exclude_draft_pr",
"dependency_check",
Expand Down Expand Up @@ -453,7 +454,8 @@ $optional_params_server = @(
"review_scope",
"enable_default_branch",
"exclude_branches",
"include_branches",
"include_source_branches",
"include_target_branches",
"exclude_files",
"exclude_draft_pr",
"dependency_check",
Expand Down Expand Up @@ -540,7 +542,7 @@ foreach ($param in $required_params) {
foreach ($param in $optional_params) {
if ($param -eq "dependency_check.snyk_auth_token" -and $props["dependency_check"] -eq "True") {
Ask-For-Param $param $false
} elseif ($param -ne "acceptable_suggestions_enabled" -and $param -ne "dependency_check.snyk_auth_token" -and $param -ne "env" -and $param -ne "cli_path" -and $param -ne "output_path" -and $param -ne "static_analysis_tool" -and $param -ne "linters_feedback" -and $param -ne "secret_scanner_feedback" -and $param -ne "enable_default_branch" -and $param -ne "git.domain" -and $param -ne "review_scope" -and $param -ne "exclude_branches" -and $param -ne "include_branches" -and $param -ne "exclude_files" -and $param -ne "exclude_draft_pr" -and $param -ne "cr_event_type" -and $param -ne "posting_to_pr" -and $param -ne "custom_rules.configured_ws_ids" -and $param -ne "custom_rules.aws_access_key_id" -and $param -ne "custom_rules.aws_secret_access_key" -and $param -ne "custom_rules.region_name" -and $param -ne "custom_rules.bucket_name" -and $param -ne "custom_rules.aes_key" -and $param -ne "code_context_config.partial_timeout" -and $param -ne "code_context_config.max_depth" -and $param -ne "code_context_config.kill_timeout_sec") {
} elseif ($param -ne "acceptable_suggestions_enabled" -and $param -ne "dependency_check.snyk_auth_token" -and $param -ne "env" -and $param -ne "cli_path" -and $param -ne "output_path" -and $param -ne "static_analysis_tool" -and $param -ne "linters_feedback" -and $param -ne "secret_scanner_feedback" -and $param -ne "enable_default_branch" -and $param -ne "git.domain" -and $param -ne "review_scope" -and $param -ne "exclude_branches" -and $param -ne "include_source_branches" -and $param -ne "include_target_branches" -and $param -ne "exclude_files" -and $param -ne "exclude_draft_pr" -and $param -ne "cr_event_type" -and $param -ne "posting_to_pr" -and $param -ne "custom_rules.configured_ws_ids" -and $param -ne "custom_rules.aws_access_key_id" -and $param -ne "custom_rules.aws_secret_access_key" -and $param -ne "custom_rules.region_name" -and $param -ne "custom_rules.bucket_name" -and $param -ne "custom_rules.aes_key" -and $param -ne "code_context_config.partial_timeout" -and $param -ne "code_context_config.max_depth" -and $param -ne "code_context_config.kill_timeout_sec") {
Ask-For-Param $param $false
}
}
Expand Down Expand Up @@ -583,8 +585,10 @@ foreach ($param in $required_params + $bee_params + $optional_params) {
$docker_cmd += " --$param=$validated_boolean"
} elseif ($param -eq "exclude_branches") {
$docker_cmd += " --exclude_branches='$($props[$param])'"
} elseif ($param -eq "include_branches") {
$docker_cmd += " --include_branches='$($props[$param])'"
} elseif ($param -eq "include_source_branches") {
$docker_cmd += " --include_source_branches='$($props[$param])'"
} elseif ($param -eq "include_target_branches") {
$docker_cmd += " --include_target_branches='$($props[$param])'"
} elseif ($param -eq "exclude_files") {
$docker_cmd += " --exclude_files='$($props[$param])'"
} elseif ($param -eq "exclude_draft_pr") {
Expand Down
14 changes: 9 additions & 5 deletions cra-scripts/bito-cra.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,7 +422,8 @@ optional_params_cli=(
"review_scope"
"enable_default_branch"
"exclude_branches"
"include_branches"
"include_source_branches"
"include_target_branches"
"exclude_files"
"exclude_draft_pr"
"dependency_check"
Expand Down Expand Up @@ -463,7 +464,8 @@ optional_params_server=(
"review_scope"
"enable_default_branch"
"exclude_branches"
"include_branches"
"include_source_branches"
"include_target_branches"
"exclude_files"
"exclude_draft_pr"
"dependency_check"
Expand Down Expand Up @@ -548,7 +550,7 @@ done
for param in "${optional_params[@]}"; do
if [ "$param" == "dependency_check.snyk_auth_token" ] && [ "${props["dependency_check"]}" == "True" ]; then
ask_for_param "$param" "False"
elif [ "$param" != "acceptable_suggestions_enabled" ] && [ "$param" != "dependency_check.snyk_auth_token" ] && [ "$param" != "env" ] && [ "$param" != "cli_path" ] && [ "$param" != "output_path" ] && [ "$param" != "static_analysis_tool" ] && [ "$param" != "linters_feedback" ] && [ "$param" != "secret_scanner_feedback" ] && [ "$param" != "enable_default_branch" ] && [ "$param" != "git.domain" ] && [ "$param" != "review_scope" ] && [ "$param" != "exclude_branches" ] && [ "$param" != "include_branches" ] && [ "$param" != "nexus_url" ] && [ "$param" != "exclude_files" ] && [ "$param" != "exclude_draft_pr" ] && [ "$param" != "cr_event_type" ] && [ "$param" != "posting_to_pr" ] && [ "$param" != "custom_rules.configured_ws_ids" ] && [ "$param" != "custom_rules.aws_access_key_id" ] && [ "$param" != "custom_rules.aws_secret_access_key" ] && [ "$param" != "custom_rules.region_name" ] && [ "$param" != "custom_rules.bucket_name" ] && [ "$param" != "custom_rules.aes_key" ] && [ "$param" != "code_context_config.partial_timeout" ] && [ "$param" != "code_context_config.max_depth" ] && [ "$param" != "code_context_config.kill_timeout_sec" ]; then
elif [ "$param" != "acceptable_suggestions_enabled" ] && [ "$param" != "dependency_check.snyk_auth_token" ] && [ "$param" != "env" ] && [ "$param" != "cli_path" ] && [ "$param" != "output_path" ] && [ "$param" != "static_analysis_tool" ] && [ "$param" != "linters_feedback" ] && [ "$param" != "secret_scanner_feedback" ] && [ "$param" != "enable_default_branch" ] && [ "$param" != "git.domain" ] && [ "$param" != "review_scope" ] && [ "$param" != "exclude_branches" ] && [ "$param" != "include_source_branches" ] && [ "$param" != "include_target_branches" ] && [ "$param" != "nexus_url" ] && [ "$param" != "exclude_files" ] && [ "$param" != "exclude_draft_pr" ] && [ "$param" != "cr_event_type" ] && [ "$param" != "posting_to_pr" ] && [ "$param" != "custom_rules.configured_ws_ids" ] && [ "$param" != "custom_rules.aws_access_key_id" ] && [ "$param" != "custom_rules.aws_secret_access_key" ] && [ "$param" != "custom_rules.region_name" ] && [ "$param" != "custom_rules.bucket_name" ] && [ "$param" != "custom_rules.aes_key" ] && [ "$param" != "code_context_config.partial_timeout" ] && [ "$param" != "code_context_config.max_depth" ] && [ "$param" != "code_context_config.kill_timeout_sec" ]; then
ask_for_param "$param" "False"
fi
done
Expand Down Expand Up @@ -597,8 +599,10 @@ for param in "${required_params[@]}" "${bee_params[@]}" "${optional_params[@]}";
docker_cmd+=" --enable_default_branch=${props[$param]}"
elif [ "$param" == "exclude_branches" ]; then
docker_cmd+=" --exclude_branches='${props[$param]}'"
elif [ "$param" == "include_branches" ]; then
docker_cmd+=" --include_branches='${props[$param]}'"
elif [ "$param" == "include_source_branches" ]; then
docker_cmd+=" --include_source_branches='${props[$param]}'"
elif [ "$param" == "include_target_branches" ]; then
docker_cmd+=" --include_target_branches='${props[$param]}'"
Comment on lines +602 to +605
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed parameter breaks backward compatibility

The code replaces include_branches with two separate parameters include_source_branches and include_target_branches, which is a logical improvement but the old parameter handling is completely removed. This could break backward compatibility for scripts using the old parameter.

Code suggestion
Check the AI-generated fix before applying
Suggested change
elif [ "$param" == "include_source_branches" ]; then
docker_cmd+=" --include_source_branches='${props[$param]}'"
elif [ "$param" == "include_target_branches" ]; then
docker_cmd+=" --include_target_branches='${props[$param]}'"
elif [ "$param" == "include_branches" ]; then
echo "Warning: 'include_branches' is deprecated. Please use 'include_source_branches' and 'include_target_branches' instead."
docker_cmd+=" --include_branches='${props[$param]}'"
elif [ "$param" == "include_source_branches" ]; then
docker_cmd+=" --include_source_branches='${props[$param]}'"
elif [ "$param" == "include_target_branches" ]; then
docker_cmd+=" --include_target_branches='${props[$param]}'"

Code Review Run #e2b0fa

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

  • Yes, avoid them

elif [ "$param" == "exclude_files" ]; then
docker_cmd+=" --exclude_files='${props[$param]}'"
elif [ "$param" == "exclude_draft_pr" ]; then
Expand Down