Skip to content

Refactor/update/jquery #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: gh-pages
Choose a base branch
from
Open

Refactor/update/jquery #2022

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93a4438
refactor: added jquery-3.7.1.min.js and jquery-ui-1.14.1.min.js
RafaelJohn9 Jul 2, 2025
b9a61b2
refactor: upgrade jquery and jquery ui version in footer
RafaelJohn9 Jul 3, 2025
cb66948
refactor: upgrade jquery and jquery ui version in application js
RafaelJohn9 Jul 3, 2025
a98da04
refactor: updated deprecated jquery methods
RafaelJohn9 Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions assets/js/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
// Read Sprockets README (https://github.com/rails/sprockets#sprockets-directives) for details
// about supported directives.
//
//= require jquery-1.7.1.min
//= require jquery-ui-1.8.18.custom.min
//= require jquery-3.7.1.min
//= require jquery-ui-1.14.1.min
Comment on lines -13 to +14
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not make much sense to split the JQuery version updates in application.js from the ones in the header.

I am glad that you dropped the unrelated change from this commit where jquery.defaultvalue was dropped. But it seems you no longer drop this altogether? Is it still supported? Does it support the newest JQuery version?

//= require jquery.defaultvalue
//= require session.min

Expand Down
Loading