Fix read-only issue with Test Custom Editor file #5631
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copilot
AI
changed the title
Copilot finished work on behalf of
dscho
May 22, 2025 06:58
|
Unfortunately, this did not work because Copilot opened the PR in the wrong repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the "Test Custom Editor" button in the Git for Windows installer, the test file opens in read-only mode for some editors (like Helix), preventing users from editing it.
This happens because the temporary file is created by the installer with restrictive permissions. This PR adds code to explicitly set permissions on the test file using the
icaclscommand, which grants full control to the Authenticated Users group.The changes:
icaclsafter creating the test file*S-1-5-11for the Authenticated Users groupTesting the change with the Helix editor should now allow editing the test file without any read-only warnings.
Fixes #5618.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.