Skip to content

Accommodate for pc-msys -> pc-cygwin change #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 23, 2025

Conversation

dscho
Copy link
Member

@dscho dscho commented Jun 22, 2025

The MSYS2 project recently switched its triplet from x86_64-pc-msys to x86_64-pc-cygwin in msys2/MSYS2-packages#5448.

To let the currently failing check-for-missing-dlls, git-artifacts and ci-artifacts builds succeed again, we need to adjust a hard-coded instance of x86_64-pc-msys.

While at it, also adjust the sdk build msys2-runtime code that also hard-codes that triplet.

dscho added 2 commits June 21, 2025 09:27
The MSYS2 project switched its triplet from `x86_64-pc-msys` to
`x86_64-pc-cygwin`. We need to accommodate for that.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The MSYS2 project switched its triplet from `x86_64-pc-msys` to
`x86_64-pc-cygwin`. We need to accommodate for that.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho self-assigned this Jun 22, 2025
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho requested review from mjcheetham and rimrul June 22, 2025 13:07
@dscho
Copy link
Member Author

dscho commented Jun 22, 2025

/deploy git-extra

The i686/x86_64 and the arm64 workflow runs were started.

KSR-Yasuda and others added 2 commits June 23, 2025 08:02
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho force-pushed the accommodate-for-pc-cygwin-change branch from b75231d to b5267d5 Compare June 23, 2025 06:08
@dscho
Copy link
Member Author

dscho commented Jun 23, 2025

/deploy git-extra

The i686/x86_64 and the arm64 workflow runs were started.

@dscho dscho merged commit 92af90e into git-for-windows:main Jun 23, 2025
20 checks passed
@dscho dscho deleted the accommodate-for-pc-cygwin-change branch June 23, 2025 06:18
@dscho
Copy link
Member Author

dscho commented Jun 23, 2025

For the record: the check-for-missing-dlls, ci-artifacts and git-artifacts runs all now succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants