Fix building the NuGet package #622
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤞 that the PR build does what it's supposed to do. |
mjcheetham
approved these changes
Jun 3, 2025
While fixing a problem during the v2.50.0-rc0 cycle, I edited `make-file-list.sh` in a way that broke `nuget/release.sh`. Unfortunately, this was only detected at the very last step of the release process. Let's catch things like this a lot earlier. Note: We do not need to bother testing `nuget/release.sh` on Windows/ARM64 because we're only building NuGet packages for x64, see https://github.com/git-for-windows/git-for-windows-automation/blob/7766f3c6afa8/.github/workflows/git-artifacts.yml#L175 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The file list must not contain unexpanded shell patterns. Otherwise building the NuGet package will fail with something like this: Target path 'tools\etc\msystem*' contains invalid characters. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
fix-nuget-package-building
branch
from
cc89cd7 to
8316103
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately the change introduced in #621 caused a breakage the
nuget/release.shscript.This PR fixes it, and modifies the PR builds so that similar issues will be caught before merging in the future.