installer: test any custom editor on a _writable_ file #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When choosing a custom editor, there is the convenient "Test Custom Editor" button. When clicking it, a file is written and the specified editor is invoked to edit that file. The file is then deleted. The contents of that file specifically encourage the user to make changes and write the file. Unfortunately, due to security concerns InnoSetup nowadays restricts the permissions of its temporary directory, which means that the file (which is written by the elevated installer process) is not writable by the (non-elevated) custom editor. Let's just write the file _next_ to that temporary directory, which is the user's TEMP directory and therefore writable. This fixes git-for-windows/git#5618. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
For shiggles, I'll ask Copilot to review. |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses a security issue where the custom editor was attempting to write to a restricted temporary directory by instead creating the file next to it in a writable location.
- Modified the path for TmpFile to use '{tmp}-editor-test.txt' for enhanced writability.
- Added DeleteFile calls in error-handling branches to ensure cleanup of the temporary file.
rimrul
approved these changes
May 22, 2025
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2025
Git for Windows' installer [used a non-writable file](git-for-windows/git#5618) for testing custom editors, which [was fixed](#618). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When choosing a custom editor, there is the convenient "Test Custom Editor" button. When clicking it, a file is written and the specified editor is invoked to edit that file. The file is then deleted.
The contents of that file specifically encourage the user to make changes and write the file.
Unfortunately, due to security concerns InnoSetup nowadays restricts the permissions of its temporary directory, which means that the file (which is written by the elevated installer process) is not writable by the (non-elevated) custom editor.
Let's just write the file next to that temporary directory, which is the user's TEMP directory and therefore writable.
This fixes git-for-windows/git#5618.